Skip to content

fix(workspace): treat legacy rootPath createAndConnect as local - #708

Merged
moreih29 merged 1 commit into
developfrom
fix/workspace-legacy-create
Nov 19, 2026
Merged

moreih29 merged 1 commit into
developfrom
fix/workspace-legacy-create

Conversation

@moreih29

Copy link
Copy Markdown
Owner

Summary

  • workspace.createAndConnect accepts the legacy { rootPath, name } shape in its schema, but the handler only took the local branch when location was present. The legacy shape fell through to createAndConnectSsh, which threw createAndConnectSsh called for non-SSH location and surfaced as an internal error.
  • The handler now treats the legacy shape as a local folder, the same way manager.create already does.

Found during Mac desktop QA for 0.35.0. No current renderer caller sends the legacy shape, so this is a hardening fix.

Test plan

  • bun run typecheck
  • bun run lint
  • bun test tests/unit/main/features/workspace tests/integration/ipc/round-trip.test.ts

🤖 Generated with Claude Code

The IPC schema accepts the legacy { rootPath, name } shape, but the
handler only took the local branch when a location field was present,
so the legacy shape fell through to createAndConnectSsh and failed with
an internal error.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@moreih29
moreih29 merged commit 994740b into develop Nov 19, 2026
7 checks passed
@moreih29
moreih29 deleted the fix/workspace-legacy-create branch November 19, 2026 17:09
@moreih29 moreih29 mentioned this pull request Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant